fix(ui): tolerate incomplete ability_info on dash cards - #3189
Draft
FhiPunkVn wants to merge 2 commits into
Draft
Conversation
|
@sophiacute2024-crypto is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 10, 2026
Member
|
@FhiPunkVn Don't mention issue numbers in comments and ideally no specific unit names either, as they might change. |
DreadKnight
marked this pull request as draft
July 10, 2026 22:46
Member
|
@FhiPunkVn Deployment of this failed |
…ngMoon#1996) Empty object fallback was typed as {} so property access failed tsc.
Member
|
@FhiPunkVn Still waiting on the comment tweak 🐻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make dash ability cards tolerate missing fields (WIP units like Kraken) instead of breaking the UI.
Fixes #1996
Change
Test plan