ADC-395 Re-nest numerics into sub-families - #222
Merged
Conversation
wolf75222
force-pushed
the
adc-394-renest-mesh
branch
from
June 22, 2026 13:45
91584d1 to
0d24113
Compare
wolf75222
force-pushed
the
adc-395-renest-numerics
branch
from
June 22, 2026 13:45
ff3790d to
642e936
Compare
wolf75222
force-pushed
the
adc-394-renest-mesh
branch
from
June 22, 2026 14:24
0d24113 to
807a1bb
Compare
Phase 4 of the include/adc reorganization (follow-up of ADC-394). Split
numerics so no directory mixes concerns: top-level into linalg/ and fv/;
spatial/ into primitives/, operators/ and embedded_boundary/; time/ into
integrators/, schemes/ and amr/ (levels, advance, reflux). The polar /
eb / embedded-boundary headers are renamed to their family
(spatial/operators/polar_operator, spatial/embedded_boundary/{operator,
domain}). The numerics/spatial_operator.hpp umbrella (ADC-328) is kept
and its internal includes repointed.
Repoint every internal include and the DSL emit (numerics/dense_eig.hpp).
Public include-path break, stacked on ADC-394. No adc_cases impact.
Validated: cmake --preset parallel (Kokkos OpenMP;Serial, AppleClang)
compiles and links all 365 targets.
wolf75222
force-pushed
the
adc-395-renest-numerics
branch
from
June 22, 2026 14:25
642e936 to
69e8450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADC-395
Phase 4 of the include/adc reorganization. Stacked on #221 (ADC-394).
What
Split
numerics/so no directory mixes concerns:linalg/(dense_eig, lorentz_eliminator),fv/(numerical_flux, reconstruction, spatial_discretisation)spatial/->primitives/(state_access, positivity, face_flux, wave_speed),operators/(cartesian_operator, masked_operator, polar_operator),embedded_boundary/(domain, operator)time/->integrators/(time_integrator, time_steppers, ssprk, implicit_stepper),schemes/(imex, splitting, scheduler),amr/(levels, advance, reflux);reference/anddeprecated/unchangedRenames:
spatial_operator_polar->spatial/operators/polar_operator,spatial_operator_eb->spatial/embedded_boundary/operator,embedded_boundary->spatial/embedded_boundary/domain.The
numerics/spatial_operator.hppumbrella (ADC-328) is kept as the single public aggregator and repointed.elliptic/was already family-layered (ADC-334).Validation
cmake --preset parallel(Kokkos OpenMP;Serial, AppleClang): all 365 targets compile and link, 0 errors. ctest running. No adc_cases impact (it does not include numerics non-elliptic headers).Next
Phase 5 (runtime + coupling finish) — the last phase.