ADC-396 Re-nest runtime and finish coupling families - #223
Merged
Conversation
wolf75222
force-pushed
the
adc-396-renest-runtime-coupling
branch
from
June 22, 2026 13:06
2b240d4 to
9b9b87d
Compare
wolf75222
force-pushed
the
adc-395-renest-numerics
branch
from
June 22, 2026 13:45
ff3790d to
642e936
Compare
wolf75222
force-pushed
the
adc-396-renest-runtime-coupling
branch
from
June 22, 2026 13:45
9b9b87d to
821df8b
Compare
wolf75222
force-pushed
the
adc-395-renest-numerics
branch
from
June 22, 2026 14:25
642e936 to
69e8450
Compare
Phase 5 (final) of the include/adc reorganization (follow-up of ADC-395). runtime/ now keeps only the public facade at top (system, amr_system, facade_options, export); detail/ splits into config/ (runtime_params, dispatch_tags, model_spec), context/ (grid_context, wall_predicate) and dynamic/ (abi_key, dynlib, dynamic_model, model_registry); builders/ splits into block/, compiled/ and factory/. coupling/static_system/ is renamed coupling/system/, and coupling/schur/ splits into core/, source/ and amr/. Repoint every internal include and the DSL emit (runtime config/dynamic/ builders paths). Public include-path break, stacked on ADC-395. No adc_cases impact. Completes the include/adc family layout. Validated: cmake --preset parallel (Kokkos OpenMP;Serial, AppleClang) compiles and links all 365 targets.
The include/adc re-nest (ADC-392..396) moved or renamed the headers that 43 markdown links across README.md and docs/ (incl. sphinx) pointed at, so check_docs flagged broken relative links. Repoint every link target to its canonical family path (e.g. runtime/system_stepper.hpp -> runtime/system/system_stepper.hpp, numerics/spatial_operator_eb.hpp -> numerics/spatial/embedded_boundary/operator.hpp). Link targets only; backtick prose mentions are a separate docs-freshness pass (ADC-397). Verified locally: check_docs reports 0 broken links. No code change.
The include/adc re-nest (ADC-392..396) moved or renamed headers that 22 live reference, design and Sphinx docs mention in prose (backtick code spans, not links). Repoint each to its canonical family path, e.g. runtime/block_builder.hpp -> runtime/builders/block/block_builder.hpp, numerics/spatial_operator_eb.hpp -> numerics/spatial/embedded_boundary/ operator.hpp. Dated audit snapshots stay historical; planned (not yet in-tree) SAMRAI/AMR modules are untouched. check_docs: 0 broken links. Docs-only, no code change. The docmap.toml freshness re-ack (reviewed sha for the strict docs) follows post-merge (ADC-397), since it needs the squashed master sha.
wolf75222
force-pushed
the
adc-396-renest-runtime-coupling
branch
from
June 22, 2026 14:26
55da40e to
cadbe5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADC-396
Phase 5 (final) of the include/adc reorganization. Stacked on #222 (ADC-395).
What
runtime/keeps only the public facade at top:system.hpp,amr_system.hpp,facade_options.hpp,export.hppruntime/detail/->config/(runtime_params, dispatch_tags, model_spec),context/(grid_context, wall_predicate),dynamic/(abi_key, dynlib, dynamic_model, model_registry)runtime/builders/->block/(block_builder, block_builder_polar, block_seam, amr_block_seam),compiled/(dsl_block, amr_dsl_block, compiled_block_abi, native_loader),factory/(model_factory)coupling/static_system/->coupling/system/coupling/schur/->core/(schur_condensation, schur_source_kernels),source/(condensed_schur_source_stepper, polar_condensed_schur_source_stepper),amr/(amr_condensed_schur_source_stepper)Every internal
#include <adc/...>and the DSL emit (runtime config/dynamic/builders paths) repointed.runtime/system/andruntime/amr/unchanged.Validation
cmake --preset parallel(Kokkos OpenMP;Serial, AppleClang): all 365 targets compile and link, 0 errors. ctest running. No adc_cases impact.Completes the include/adc family layout
Final phase of the ADC-392..396 series (remove shims -> core/physics/amr -> mesh -> numerics -> runtime/coupling). No directory mixes abstraction levels; one canonical path per header.