ADC-393 Re-nest core, physics, amr into sub-families - #224
Merged
Conversation
Phase 2 of the include/adc reorganization (follow-up of ADC-392). Split
the still-flat foundational layers so no directory mixes abstraction
levels: core into foundation/state/model, physics into
bricks/composition/fluids, amr into hierarchy/tagging/regridding.
Repoint every internal include and the DSL emit (physics/bricks.hpp,
core/variables.hpp). Also retire the deprecated physics compat
forwarders physics/{advection_diffusion,langmuir,two_fluid_isothermal}
.hpp and their dedicated test_physics_validation_compat: those bricks
live at validation/physics under adc::validation since ADC-329, and
nothing else used the adc:: aliases.
Public include-path break, stacked on ADC-392.
Validated: cmake --preset parallel (Kokkos OpenMP;Serial, AppleClang)
compiles and links all 365 targets.
wolf75222
force-pushed
the
adc-393-renest-core-physics-amr
branch
from
June 22, 2026 14:23
654c26f to
256d86e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADC-393. Replaces #220 (auto-closed when #219 merged and its base branch was deleted). Same commit 654c26f, gate already passed there. Stacked reorg phase 2; #221/#222/#223 follow.