ADC-394 Re-nest mesh into sub-families - #221
Merged
Merged
Conversation
wolf75222
force-pushed
the
adc-394-renest-mesh
branch
from
June 22, 2026 13:45
91584d1 to
0d24113
Compare
wolf75222
force-pushed
the
adc-393-renest-core-physics-amr
branch
from
June 22, 2026 14:23
654c26f to
256d86e
Compare
Phase 3 of the include/adc reorganization (follow-up of ADC-393). Split the flat 14-header mesh/ directory so no directory mixes concerns: index/ (box2d, box_hash), layout/ (box_array, patch_box, distribution_mapping, refinement), storage/ (fab2d, multifab, mf_arith), geometry/ (geometry), boundary/ (physical_bc, halo_schedule, fill_boundary), execution/ (for_each). Repoint every internal include AND the dsl.py adc_include() probe (adc/mesh/multifab.hpp -> adc/mesh/storage/multifab.hpp, a non-#include path check the family rewrite had missed -> broke the DSL test gate). Public include-path break, stacked on ADC-393. Companion: adc_cases two_fluid_ap mesh includes (adc_cases PR 50). Validated: cmake --preset parallel (C++ 365 targets) + python suite (test_dsl_compile_cache et al.) green.
wolf75222
force-pushed
the
adc-394-renest-mesh
branch
from
June 22, 2026 14:24
0d24113 to
807a1bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADC-394
Phase 3 of the include/adc reorganization. Stacked on #220 (ADC-393) — base is the ADC-393 branch.
What
Split the flat 14-header
mesh/directory into sub-families:index/(box2d, box_hash)layout/(box_array, patch_box, distribution_mapping, refinement)storage/(fab2d, multifab, mf_arith)geometry/(geometry)boundary/(physical_bc, halo_schedule, fill_boundary)execution/(for_each)Every internal
#include <adc/...>is repointed (also the one comment reference in rootCMakeLists.txt).Companion
adc_casestwo_fluid_apuses 8 of these mesh paths -> updated in adc_cases #50 (merge after this lands; the newmesh/*paths exist only then).Validation
cmake --preset parallel(Kokkos OpenMP;Serial, AppleClang): all 365 targets compile and link, 0 errors. ctest running.Next
Phase 4 (numerics: linalg/fv/spatial/time), then runtime + coupling finish.