Repository navigation
style(ui-copy): remove terminal punctuation from secondary copy - #1823
Merged
FresnelR27 merged 1 commit intoSep 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Secondary supporting copy across settings, modals, and wizards inconsistently ended with sentence punctuation (
.or。), including the GitHub authentication setup flow shown in the reported screenshotSolution
Removed only terminal
.and。from supporting-copy translations across the locale catalogs and from the Git connection wizard fallback strings. Internal punctuation, ellipses, wording, keys, placeholders, and behavior are unchanged. Added the required frontend UI audit report for the wizard surfacePotential risks
This is a copy-only change spanning 93 locale JSON files plus two wizard components. It does not change runtime behavior, layout rules, keys, or interpolation placeholders. Dependency-based checks were run in the original checkout; the isolated PR worktree does not contain
node_modulesVerification
git diff --check origin/develop...HEAD— passedpnpm run test:i18n-keys— passed in the source checkout: 27 testspnpm exec vitest run --config config/vitest.config.ts src/scaffold/WizardSystem/primitives/__tests__/SelectionGrid.test.ts src/features/Onboarding/OnboardingModal.test.ts— passed in the source checkout: 12 testspnpm exec eslint src/scaffold/WizardSystem/variants/Channel/ChannelSections.tsx src/scaffold/WizardSystem/variants/Channel/ChannelWizard.tsx— passed in the source checkoutpnpm exec prettier --check src/scaffold/WizardSystem/variants/Channel/ChannelSections.tsx src/scaffold/WizardSystem/variants/Channel/ChannelWizard.tsx docs/frontend-ui-audit-2026-09-15/GitConnectionWizard.md— passed in the source checkoutpnpm run check:i18n-keys— not clean because of the unrelated pre-existing unused keysessions:simulator.titleBar.showBottomPanel; missing keys, locale gaps, and placeholder mismatches were zeroNODE_OPTIONS=--max-old-space-size=8192 pnpm run typecheck— not clean because of unrelated pre-existing SearchInput and chat-history type errors; no errors were reported in the changed wizard files