Skip to content

style(ui-copy): remove terminal punctuation from secondary copy - #1823

Merged
FresnelR27 merged 1 commit into
org2AI:developfrom
Harry19081:dev/settings-copy-punctuation
Sep 15, 2026
Merged

FresnelR27 merged 1 commit into
org2AI:developfrom
Harry19081:dev/settings-copy-punctuation

Conversation

@Harry19081

Copy link
Copy Markdown
Member

Problem

Secondary supporting copy across settings, modals, and wizards inconsistently ended with sentence punctuation (. or 。), including the GitHub authentication setup flow shown in the reported screenshot

Solution

Removed only terminal . and 。 from supporting-copy translations across the locale catalogs and from the Git connection wizard fallback strings. Internal punctuation, ellipses, wording, keys, placeholders, and behavior are unchanged. Added the required frontend UI audit report for the wizard surface

Potential risks

This is a copy-only change spanning 93 locale JSON files plus two wizard components. It does not change runtime behavior, layout rules, keys, or interpolation placeholders. Dependency-based checks were run in the original checkout; the isolated PR worktree does not contain node_modules

Verification

  • git diff --check origin/develop...HEAD — passed
  • Dependency-free validation on the exact rebased commit — passed: 93 locale JSON files parsed; 1,383 replacements verified as single terminal punctuation removals; 0 unexpected replacement pairs
  • pnpm run test:i18n-keys — passed in the source checkout: 27 tests
  • pnpm exec vitest run --config config/vitest.config.ts src/scaffold/WizardSystem/primitives/__tests__/SelectionGrid.test.ts src/features/Onboarding/OnboardingModal.test.ts — passed in the source checkout: 12 tests
  • pnpm exec eslint src/scaffold/WizardSystem/variants/Channel/ChannelSections.tsx src/scaffold/WizardSystem/variants/Channel/ChannelWizard.tsx — passed in the source checkout
  • pnpm exec prettier --check src/scaffold/WizardSystem/variants/Channel/ChannelSections.tsx src/scaffold/WizardSystem/variants/Channel/ChannelWizard.tsx docs/frontend-ui-audit-2026-09-15/GitConnectionWizard.md — passed in the source checkout
  • pnpm run check:i18n-keys — not clean because of the unrelated pre-existing unused key sessions:simulator.titleBar.showBottomPanel; missing keys, locale gaps, and placeholder mismatches were zero
  • NODE_OPTIONS=--max-old-space-size=8192 pnpm run typecheck — not clean because of unrelated pre-existing SearchInput and chat-history type errors; no errors were reported in the changed wizard files
  • No screenshot added: this change removes terminal copy punctuation and does not alter layout or visual states

@FresnelR27
FresnelR27 merged commit 52787b2 into org2AI:develop Sep 15, 2026
14 checks passed
@Harry19081 Harry19081 added UX Improvements to user experience, workflow smoothness frontend-ui Frontend UI, design system, accessibility, layout, or theming labels Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend-ui Frontend UI, design system, accessibility, layout, or theming UX Improvements to user experience, workflow smoothness

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants