Repository navigation
fe: cancel a login that waits on the server, the spinner over the page left no way out - #209
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryLogin now waits inside the modal instead of covering the page.
The unnumbered previous finding is addressed: the queued submit now checks that the form is still waiting before sending it. No new actionable issues were found.
|
…answers held every other page Adminer kept the session locked through Driver::connect(), so while a login waited on a silent server, every other request in the window waited on the lock. The patch closes the session first and reopens it only to write the token or a failed login.
…e left no way out While a login waits, Login turns into a turning Cancel inside the modal, in place of the indicator over the whole page. Cancel, Escape or the close button stops the request with window.stop().
busy.js sends the form two frames after the click. A Cancel in between took the wait down, but the login was still sent, with no Cancel left to stop it.
landsman
force-pushed
the
cancel-login
branch
from
October 25, 2026 12:57
b5e3271 to
db4f1ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A login to a host that never answers covered the page with a spinner, and nothing could stop it before the connection timed out, minutes later on some networks.
While a login waits now, the modal's fields are dimmed and Login turns into a spinning Cancel. The page-wide indicator is gone. Cancel, Escape or × stops the request with
window.stop().Cancelling in the browser alone would not have helped. Adminer kept the PHP session locked through
Driver::connect(), so after a cancel, every other page in the window still waited for the stuck connect.patches/adminer-connect-without-session-lock.patchcloses the session before connecting and reopens it only to write the token or a failed login. Upstream: vrana/adminer#1369 The connect itself keeps running on its server thread until libpq gives up; PHP cannot interrupt it.The new scenario logs in to the silent test server, presses Cancel and checks two things: the form still holds what was typed, and the next page in the session answers within 1 s. Without the patch that page takes ~2 s and the scenario fails. Cancel is pressed with a raw mouse click, because Playwright's
click(),evaluate()andwaitForFunction()all wait until a pending navigation ends.make qa,make checkand the fullmake e2e(162 + 40 + 3 scenarios) pass. Checked in Chromium only, not yet in WKWebView.