Repository navigation
fe: keep a waiting login open on a click outside, the × asks before it stops connecting - #212
Merged
Merged
Conversation
…t stops connecting
[Medium impact] The PR appears safe to merge; both previous findings are addressed. SummaryThe follow-up protects the actual dialog close path and strengthens the confirmation tests.
Reviews (2) · Last reviewed commit: "fe: reopen a waiting login that chromium..." · Reviewed by Greptile |
…nd prove the × asks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #209. While a login waited, a click outside the modal closed it, and with it the login, and the pointer showed a hand over the whole window.
Now, while it waits, Escape and a click outside do nothing; Cancel stops it as before, and the × asks "Stop connecting?" first, Keep waiting focused. The window shows the busy cursor, the backdrop included, and only the buttons keep the pointer.
The cursor was set explicitly rather than traced to whatever drew the hand; the e2e asserts the computed
progress, which headless WebKit can show but not paint. Three scenarios cover the click outside, × → Stop and × → Keep waiting. A close that still finds the login waiting, as Chromium allows on a second Escape, reopens the modal.