Skip to content

fe: keep a waiting login open on a click outside, the × asks before it stops connecting - #212

Merged
landsman merged 2 commits into
mainfrom
fe/login-wait-modal
Oct 25, 2026
Merged

landsman merged 2 commits into
mainfrom
fe/login-wait-modal

Conversation

@landsman

@landsman landsman commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Follows #209. While a login waited, a click outside the modal closed it, and with it the login, and the pointer showed a hand over the whole window.

Now, while it waits, Escape and a click outside do nothing; Cancel stops it as before, and the × asks "Stop connecting?" first, Keep waiting focused. The window shows the busy cursor, the backdrop included, and only the buttons keep the pointer.

The cursor was set explicitly rather than traced to whatever drew the hand; the e2e asserts the computed progress, which headless WebKit can show but not paint. Three scenarios cover the click outside, × → Stop and × → Keep waiting. A close that still finds the login waiting, as Chromium allows on a second Escape, reopens the modal.

@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous findings are addressed.

Summary

The follow-up protects the actual dialog close path and strengthens the confirmation tests.

  • A waiting login stays open until you choose how to leave.

Reviews (2) · Last reviewed commit: "fe: reopen a waiting login that chromium..." · Reviewed by Greptile

Comment thread tests/e2e/bootstrap/DesktopContext.php Resolved
@landsman
landsman merged commit 4df31ab into main Oct 25, 2026
6 checks passed
@landsman
landsman deleted the fe/login-wait-modal branch October 25, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant