Skip to content

fe: stop a wait under the activity indicator, a saved connection whose server never answers turned until it timed out - #218

Merged
landsman merged 2 commits into
mainfrom
busy-stop
Oct 25, 2026
Merged

landsman merged 2 commits into
mainfrom
busy-stop

Conversation

@landsman

@landsman landsman commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

A saved connection's card is a link, so its wait shows the page's indicator, which had no way out: a server that never answers kept it turning until the connection timed out. The indicator now carries a Stop, and Escape does the same: window.stop(), as the login modal's Cancel does since #209. Adminer already lets the session go before it connects, so the next page answers at once.

  • Stop fades in 3 s into the wait, below the spinner, so a quick answer never shows it.
  • It takes a click while still transparent: an animated pointer-events: none stays none in WebKit once the page is navigating, so holding it off made Stop unclickable.
  • Paging and sorting fetch rows in place, which window.stop() does not reach. Stop also aborts that fetch (a desktop-stop event), so the rows and the url stay as they were and no fallback reload starts; the pager goes back to the page still on screen.
  • The scenario sends the login under the page's indicator, not in the modal. A card's click is the same GET the login redirects to, and a card to a server that never answers would need its password saved. It gets an 8 s slow server, since 3 s answered before Stop came in.
  • An open modal leaves the indicator inert, so Stop cannot be clicked over one. No wait under the indicator happens over a modal today.

…e server never answers turned until it timed out
@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the previous cancellation issue is fixed.

Summary

Adds Stop and Escape support to the page’s activity indicator.

  • The page indicator can stop a wait with a click or Escape.
  • Stopped table fetches leave the rows and page selection in place.

Diagram

sequenceDiagram
  participant User
  participant Busy as busy.js
  participant Refresh as desktopRefresh()
  User->>Busy: Click Stop or press Escape
  Busy->>Busy: Stop navigation and hide indicator
  Busy->>Refresh: desktop-stop
  Refresh->>Refresh: Abort pending request
  Refresh-->>User: Keep current rows and URL
Loading

Reviews (2) · Last reviewed commit: "fe: let Stop drop rows fetched in place ..." · Reviewed by Greptile

Comment thread app/src/Assets/javascript/busy.js Resolved
@landsman
landsman merged commit 9e172b4 into main Oct 25, 2026
7 checks passed
@landsman
landsman deleted the busy-stop branch October 25, 2026 16:16
landsman added a commit that referenced this pull request Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant