remove: findMaxValue, dead code with no real callers and three confirmed bugs - #465
Merged
Merged
Conversation
…med bugs findMaxValue.m has never had a caller anywhere in the GECKO tree, and has three real bugs: a stale 'EC' prefix plus a broken wildcard slice mean BRENDA matching can never succeed at all (wildcarded or not), and a 0-vs-0 tie is mislabeled as a genuine 'SA*Mw' result instead of an empty match. geckopy's find_max_value already gets all three right, so this is one-sided dead weight rather than a real port target. raven-gecko-parity#81
Unit test results51 tests 51 ✅ 10s ⏱️ Results for commit 39d5dac. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findMaxValue.mhas never had a caller anywhere in the GECKO tree, and has three real bugs (confirmed by tracing both sides against the actual BRENDA data format both toolboxes now load — see raven-gecko-parity#81):'EC'prefix means BRENDA matching can never succeed at all, wildcarded or not.'SA*Mw'result instead of an empty match.geckopy's
find_max_valuealready gets all three right, so fixing dead code wasn't worth it — removed instead. Also drops itsVerificationMatrix.tsvrow.Fixes raven-gecko-parity#81
Test plan
geckoCoreFunctionTests: 51 passed, 0 failed (RAVEN develop3 on path, glpk solver)