Repository navigation
feat(browser-actions): annotate step for instructional recordings - #2551
Merged
Merged
Conversation
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2548.
New
annotatestep kind that renders into an isolated overlay: its own shadow root,pointer-events: none, top z-index, re-anchored on scroll and resize. It doesn't need theevaluategrant.highlight(ring / box / underline)spotlight(dims the viewport except the target's padded box)arrow(SVG, placed bydirection, with an optionaldrawstroke animation)label(anchored to a target)caption(position: top|center|bottom)id,durationMs(auto-clear), andanimate(draw|fade|none).clear: [ids] | trueremoves them.annotation-theme-json=<object|@file>: accentColor, textColor, background, fontFamily, fontSize, strokeWidth, radius. Neutral defaults, no per-step theme.positionis one shared field typed"top"|"center"|"bottom".scroll(feat(browser-actions): visible pointer, human-paced motion and smooth scroll step #2550) still accepts only top/bottom, and caption accepts all three. The issue'sfromwas renamed todirectionto avoid colliding withdrag.from.Tests
npm run buildclean.browser-annotations.browser.test.ts2/2: shape/clear validation, plus an overlay that doesn't intercept clicks, follows scrolling and clears by idtest:browser-video-capture4/4browser-preview-routing16/16Follow-ups (not blocking)
setBrowserAnnotationTheme). Threading it through the step executor would be cleaner for concurrent sessions.Drafted by Homeboy cooks (
cook-detached-fa0ce1e3,cook-detached-282c847a,cook-detached-ea28c3dd). Gates passed, but publication stalled (promotion_operation: operation_in_progress). With Chris's authorization, the annotation changes were applied onto currentmain(after #2549 and #2550), re-verified, and published outside Homeboy.AI-assisted: drafted by an OpenCode agent, reviewed and finalized by Extra Chill Bot.