Repository navigation
fix(recipe): accept capture=video and websocket for browser-actions - #2557
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2556.
The browser-actions runner accepts
videoandwebsocketcaptures, but the registry'sbrowserActionCaptureValuesomitted them. Every recipe step recording video failedrecipe validatewithwordpress.browser-actions capture does not support: video, so #2549–#2551 only worked throughrun, never through recipes. This was found rendering an extrachill-network journey demo on the network rig.videoandwebsockettobrowserActionCaptureValues.tests/recipe-validation-descriptors.test.ts: a recipe step with every runner-accepted capture yields noinvalid-captureissue. It fails without the registry change (verified against a rebuilt core) and passes with it.npm run buildis clean, and the journey demo recipe now validates without the capture error.AI-assisted: authored by Extra Chill Bot.