Skip to content

Fix ty 0.0.85 diagnostics in vortex-python #10353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connortsui20 wants to merge 1 commit into from
Closed

Fix ty 0.0.85 diagnostics in vortex-python #10353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vortex-python/python/vortex/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from __future__ import annotations

import warnings
from collections.abc import Iterator
from collections.abc import Generator, Iterator
from contextlib import contextmanager
from functools import reduce
from typing import final
Expand All @@ -23,7 +23,7 @@


@contextmanager
def _temporary_worker_threads(use_threads: bool) -> Iterator[None]:
def _temporary_worker_threads(use_threads: bool) -> Generator[None]:
previous_workers = _worker_threads()
if use_threads:
_set_worker_threads(None)
Expand Down
2 changes: 1 addition & 1 deletion vortex-python/test/test_expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def names(vxf: vx.VortexFile, expr: Expr) -> list[str | None]:

def column_values(vxf: vx.VortexFile, projection: Expr) -> list[object]:
table = vxf.scan(ve.pack({"value": projection})).read_all().to_arrow_table()
return cast(list[object], table.column("value").to_pylist())
return table.column("value").to_pylist()


# --------------------------------------------------------------------------------------
Expand Down
Loading