Repository navigation
Fix ty 0.0.85 diagnostics in vortex-python - #10353
connortsui20 wants to merge 1 commit into
Conversation
CI runs `uvx ty check` without a version pin, so ty 0.0.85 now fails `Python (lint)` on every branch. It wants `Generator[None]` instead of `Iterator[None]` on a `@contextmanager`, and it flags a redundant `cast` in `test_expr.py`. Both changes are annotation-only and also pass ty 0.0.84. Signed-off-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018FefTpTuDky8bGPr5R9Loq
Merging this PR will improve performance by 19.86%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | bitpack_blocked_compress_avx512 |
5.6 µs | 4.7 µs | +19.86% |
| 🆕 | Simulation | integer_stats_all_non_null |
N/A | 1.2 ms | N/A |
| 🆕 | Simulation | integer_stats_all_nullable |
N/A | 3.6 ms | N/A |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ct/ty-0.0.85-diagnostics (7326b0b) with develop (d9ad4cf)2
Footnotes
-
518 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(9eb20ba) during the generation of this report, so d9ad4cf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Summary
Python (lint)runsuvx ty checkwithout a version pin, soty0.0.85 now fails it ondevelopand every open PR, including #10340.Changes
Annotates the
@contextmanagerindataset.pyasGenerator[None]instead ofIterator[None]and drops a redundantcastintest_expr.py. Both changes are annotation-only and also passty0.0.84.