Skip to content

fix(tests): restore require_api_key in saved_views auth rejection tests #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SHAROZ221 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): restore require_api_key in saved_views auth rejection tests #2062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions testing/backend/unit/test_saved_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,19 +357,31 @@ async def test_filter_json_with_null_values_rejected(app_client: AsyncClient):
@pytest.mark.asyncio
async def test_unauthenticated_request_rejected(app_client: AsyncClient):
"""Requests without a valid API key/session are rejected, not served."""
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": ""}
)
assert res.status_code == 401
app = app_client.test_transport.app
old_override = app.dependency_overrides.pop(require_api_key, None)
try:
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": ""}
)
assert res.status_code == 401
finally:
if old_override is not None:
app.dependency_overrides[require_api_key] = old_override


@pytest.mark.asyncio
async def test_wrong_api_key_rejected(app_client: AsyncClient):
"""A malformed/incorrect API key is rejected."""
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": "not-the-real-key"}
)
assert res.status_code == 401
app = app_client.test_transport.app
old_override = app.dependency_overrides.pop(require_api_key, None)
try:
res = await app_client.get(
"/api/v1/saved-views", headers={"X-Api-Key": "not-the-real-key"}
)
assert res.status_code == 401
finally:
if old_override is not None:
app.dependency_overrides[require_api_key] = old_override


@pytest.mark.asyncio
Expand Down
Loading