fix(tests): restore require_api_key in saved_views auth rejection tests#2062
Open
SHAROZ221 wants to merge 2 commits into
Open
fix(tests): restore require_api_key in saved_views auth rejection tests#2062SHAROZ221 wants to merge 2 commits into
SHAROZ221 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes failing auth rejection unit tests in
testing/backend/unit/test_saved_views.py(test_unauthenticated_request_rejectedandtest_wrong_api_key_rejected).Because
app_clientfixture sets_app.dependency_overrides[require_api_key] = _mock_require_api_key, requests with empty or incorrect API keys were bypassing authentication and returning200 OKinstead of401 Unauthorized.This PR temporarily restores
require_api_keyfor those two auth rejection tests, bringingtest_saved_views.pyto 47/47 PASSED (100%).Contributed as part of GSSoC (GirlScript Summer of Code).
Related Issues
Fixes failing auth tests in
testing/backend/unit/test_saved_views.py.Type of Change
How Has This Been Tested?
Ran pytest directly on
testing/backend/unit/test_saved_views.py: