Repository navigation
fix: add iam policies and lakeformation changes for legacy loading - #288
Merged
Merged
Conversation
Member
Author
There was a problem hiding this comment.
🔵 Needs a closer look
Production permission changes and the AWS provider upgrade need human-reviewed Terraform plans to confirm deployment impact.
No open issues 🎉
2 files not reviewed
infra/redshift/environments/dev/.terraform.lock.hcl: Generated fileinfra/redshift/environments/prod/.terraform.lock.hcl: Generated file
What changed in this PR
This PR enables legacy data loading by extending the Orcavault runner’s source permissions and increasing compute capacity in development and production.
Changes:
- Add
data_portalLake Formation grants and S3 access for the legacy export prefix. - Make source databases, bucket, and prefixes explicit module inputs, with tests for source permissions.
- Increase Fargate resources and Redshift maximum capacity, and upgrade the Redshift AWS provider.
| File | Description |
|---|---|
infra/redshift/environments/prod/main.tf |
Raise maximum capacity to 8 RPUs and update the provider requirement. |
infra/redshift/environments/prod/.terraform.lock.hcl |
Lock AWS provider 6.70.0 and refresh checksums. |
infra/redshift/environments/dev/main.tf |
Apply matching capacity and provider changes in development. |
infra/redshift/environments/dev/.terraform.lock.hcl |
Lock AWS provider 6.70.0 and refresh checksums. |
infra/orcavault-run/modules/orcavault-run/variables.tf |
Require explicit source inputs and increase Fargate CPU and memory. |
infra/orcavault-run/modules/orcavault-run/test_orcavault_run.tftest.hcl |
Add source inputs and assertions for database grants and S3 prefixes. |
infra/orcavault-run/modules/orcavault-run/main.tf |
Use the renamed bucket input. |
infra/orcavault-run/modules/orcavault-run/lakeformation.tf |
Grant access to all configured source databases. |
infra/orcavault-run/modules/orcavault-run/iam.tf |
Support multiple S3 prefixes for listing and reading files. |
infra/orcavault-run/environments/prod/main.tf |
Configure CDC and legacy data sources explicitly. |
infra/orcavault-run/environments/dev/main.tf |
Configure the same source access for development. |
Review effort: Balanced
Member
|
reviewing... |
Member
|
(to kiro) This should tick "bump the Redshift Serverless capacity to base_capacity = 4, max_capacity = 8 RPU via Terraform". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From yesterday's debugging session: