Skip to content

Improve coverage for Intl.Locale constructor #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ms2ger merged 1 commit into from
Sep 21, 2026
Merged

Improve coverage for Intl.Locale constructor #5138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions test/intl402/Locale/constructor-unicode-extension-uvalue-true.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,24 @@ features: [Intl.Locale]
---*/

// Generate all possible `ukey` values.
// https://unicode.org/reports/tr35/#ukey
function* ukeys() {
const lowerA = 'a'.charCodeAt(0);
const lowerZ = 'z'.charCodeAt(0);
const lowerAlpha = 'abcdefghijklmnopqrstuvwxyz';
const lowerAlphanum = lowerAlpha + '0123456789';

for (let first = lowerA; first <= lowerZ; ++first) {
for (let second = lowerA; second <= lowerZ; ++second) {
yield String.fromCharCode(first, second);
for (let i = 0; i < lowerAlphanum.length; ++i) {
for (let j = 0; j < lowerAlpha.length; ++j) {
yield lowerAlphanum[i] + lowerAlpha[j];
}
}
}

for (let ukey of ukeys()) {
const localeId = `en-u-${ukey}-true`;
const normalizedLocaleId = `en-u-${ukey}`;
assert.sameValue(
new Intl.Locale(`en-u-${ukey}-true`).toString(),
`en-u-${ukey}`,
`new Intl.Locale("en-u-${ukey}-true").toString() returns "en-u-${ukey}"`
new Intl.Locale(localeId).toString(),
normalizedLocaleId,
`new Intl.Locale("${localeId}").toString() must be "${normalizedLocaleId}"`
);
}
52 changes: 18 additions & 34 deletions test/intl402/Locale/constructor-unicode-extension-uvalue-yes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
/*---
esid: sec-intl.locale
description: >
Remove any uvalue (aka type) equal to "true".
Remove any uvalue (aka type) equal to "yes" if and only if "yes" is an alias for "true".
info: |
Intl.Locale ( tag [ , options ] )
...
Expand All @@ -16,47 +16,31 @@ features: [Intl.Locale]
---*/

// Generate all possible `ukey` values.
// https://unicode.org/reports/tr35/#ukey
function* ukeys() {
const lowerA = 'a'.charCodeAt(0);
const lowerZ = 'z'.charCodeAt(0);
const lowerAlpha = 'abcdefghijklmnopqrstuvwxyz';
const lowerAlphanum = lowerAlpha + '0123456789';

for (let first = lowerA; first <= lowerZ; ++first) {
for (let second = lowerA; second <= lowerZ; ++second) {
yield String.fromCharCode(first, second);
for (let i = 0; i < lowerAlphanum.length; ++i) {
for (let j = 0; j < lowerAlpha.length; ++j) {
yield lowerAlphanum[i] + lowerAlpha[j];
}
}
}

function canonicalizeUValue(ukey, uvalue) {
assert.sameValue(uvalue, "yes", "unexpected uvalue");

switch (ukey) {
case "kb":
case "kc":
case "kh":
case "kk":
case "kn":
// Canonicalized to "true", which then gets removed.
return "";
default:
return uvalue;
}
// Whether ukey has a "yes" alias for "true" in
// https://github.com/unicode-org/cldr/blob/maint/maint-48/common/bcp47/collation.xml
function hasAlias(ukey) {
return ukey === "kb" || ukey === "kc" || ukey === "kh" || ukey === "kk" || ukey === "kn";
}

for (let ukey of ukeys()) {
let canonicalized = new Intl.Locale(`en-u-${ukey}-yes`).toString();
const localeId = `en-u-${ukey}-yes`;
const normalizedLocaleId = hasAlias(ukey) ? `en-u-${ukey}` : localeId;

if (canonicalizeUValue(ukey, "yes") === "yes") {
assert.sameValue(
canonicalized,
`en-u-${ukey}-yes`,
`new Intl.Locale("en-u-${ukey}-yes").toString() returns "en-u-${ukey}-yes"`
);
} else {
assert.sameValue(
canonicalized,
`en-u-${ukey}`,
`new Intl.Locale("en-u-${ukey}-yes").toString() returns "en-u-${ukey}"`
);
}
assert.sameValue(
new Intl.Locale(localeId).toString(),
normalizedLocaleId,
`new Intl.Locale("${localeId}").toString() must be "${normalizedLocaleId}"`
);
}
Loading