Skip to content

Improve coverage for Intl.Locale constructor - #5138

Merged
Ms2ger merged 1 commit into
tc39:mainfrom
jugglinmike:intl-improve-locale-ctor-coverage
Sep 21, 2026
Merged

Ms2ger merged 1 commit into
tc39:mainfrom
jugglinmike:intl-improve-locale-ctor-coverage

Conversation

@jugglinmike

Copy link
Copy Markdown
Contributor

This patch was originally authored by Richard Gibson:

#5016

This patch was originally authored by Richard Gibson:

tc39#5016
@jugglinmike
jugglinmike requested a review from a team as a code owner September 20, 2026 19:23
@github-actions

Copy link
Copy Markdown

2 new or modified tests were run on 7 engines.

View workflow run

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
intl402/Locale/constructor-unicode-extension-uvalue-true.js ❌ ✅ ✅ ❌ ✅ ✅ ❌
intl402/Locale/constructor-unicode-extension-uvalue-yes.js ❌ ✅ ❌ ❌ ✅ ❌ ❌

@gibson042 gibson042 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit Obama Giving Himself a Medal, but LGTM.

@Ms2ger Ms2ger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Obama

@Ms2ger
Ms2ger merged commit 95ad0fc into tc39:main Sep 21, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants