Repository navigation
Name the independent review neutrally in the README and in code comments - #40
Merged
Merged
Conversation
Text only. The README and the comments in src/preprocessor.js and src/engine.js named the reviewer and its case numbers. They now say "the independent review" and describe the case in words. Every measurement and every number is kept. No line of code changes.
azrollin
marked this pull request as ready for review
October 14, 2026 15:47
azrollin
force-pushed
the
t10/neutral-wording-w40
branch
from
October 14, 2026 15:48
ebac260 to
dc53e80
Compare
azrollin
added a commit
that referenced
this pull request
Oct 14, 2026
…t unchanged (#41) Comment-only wording pass over the twelve files that #40 declared unchanged: controls/ helper comments, root helper comments and docstrings, and the comment strings in pattern_field_contract.json. Reviewer and seat names become "the independent review", digit-numbered rounds become words or are dropped, and the one quoted error message in a comment is reworded while the run-time message itself is untouched. No key, value, code line or test changes. Proof: every changed file is byte-identical to main once comments, docstrings and _comment strings are stripped (12/12), and the node suite on the head matches main (263 pass, 0 fail). Retained on purpose, listed in the PR description: string literals, paths and file names that carry a name, and the ordinal-word round references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text only. The README and the comments in
src/preprocessor.jsandsrc/engine.jsnamed the independent reviewer and used its case numbers and fixture names. They now say "the independent review" and describe each case in words. Every measured quantity, count, date and rule id is kept; two case numbers and one fixture glob are dropped on purpose, and the review round written as a numeral in one comment is written as a word. No line of code changes.What changed
README.md(3 places): the reviewer's name becomes "the independent review" / "an independent review of 2026-09-13", and a pronoun for it becomes "its".src/preprocessor.js(7 comments): the reviewer's name, two case numbers (C01978,C01982) and a fixture glob (gap_U1C_*) are replaced by plain descriptions of the case.src/engine.js(3 comments): the reviewer's name and a pronoun.Proof that no code changed
git diff --stat: README.md 11 lines,src/engine.js6,src/preprocessor.js14.main(src/engine.jssha1 cd5134d293dc,src/preprocessor.jssha1 d69816097f6d, same on both sides).node --test tests/*.test.mjs: 180 pass, 0 fail, the same count asmain.Not changed
The reviewer's name still appears in a few places outside the README and the shipped source files this change covers, and this change does not touch them: some root level helper scripts, the recompile notes, the files under
controls/(in file names and comments), and three comment strings inpattern_field_contract.json(lines 3, 24 and 100). They are tooling, history and a contract file, and renaming or rewording them is a separate change.Other model, vendor and public project names also stay. They are product names (README,
src/index.js,src/github.js), the two public project names insrc/policy.js, and matching data insrc/patterns.js; none of them is attribution to the independent review, and deleting them mechanically would change what the scanner matches.