Repository navigation
Name the independent review neutrally in the helper scripts, controls and contract comments - #41
Merged
Merged
Conversation
… and contract comments Text only. Comments and comment strings in the root helper scripts, the files under controls/ and pattern_field_contract.json named the independent reviewer, used its case numbers and a fixture glob, and referred to it with a pronoun and a numbered round. They now say "the independent review", describe each case in words and write the rounds as words. Every measured quantity, count, date and hash is kept. No code, key or value changes. With comments (and, in the Python files, docstrings; in the contract, the _comment strings) removed, every changed file is identical to main. Runtime output strings that still carry the name are left as they are, along with file names, the data files under controls/candidates/ and the recompile notes.
Follow-up to the previous commit on this branch. Comment text only. Comments that named people or seats, or that referred to review rounds by number, now say "an earlier version" or "a later review" instead. Sites: _vflag_disclosure_gate.mjs, prep_recompile.sh, controls/metadata_is_measured.mjs, controls/_metadata_one_key.mjs, controls/guard_selftest.sh and the _comment strings in pattern_field_contract.json. The comment in prep_recompile.sh that quoted an old error now describes it neutrally; the run-time die message in prep_recompile_v058.sh is unchanged. No code changed. Every touched file still equals main once comments are stripped (docstrings and _comment strings for .py and .json).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root helper scripts, the files under
controls/andpattern_field_contract.jsoncarried comments that named the independent reviewer, used its case numbers and a fixture glob, named people or seats, and numbered review rounds. This is the second half of the wording change in #40. Those comments now say "the independent review", "an earlier version" or "a later review", describe each case in words, and no longer carry digit-numbered review labels ("round 5", "R5", "X1"). The change is in comments, docstrings and_commentstrings only; no line of code, no key and no value changes.The branch has two commits. The second one fixes the sites that the first one missed after review. The message of the first commit says more than it did; this description is the accurate one.
What changed
12 files, 67 lines in, 67 out:
_compare_compiled.mjs(1),_source_parity.py(2),_vflag_disclosure_gate.mjs(7),compile_patterns.py(9), the differential parity script named after the reviewer (6),prep_recompile.sh(13),prep_recompile_v058.sh(6). Comments, plus the docstrings in the Python files.controls/:_metadata_one_key.mjs(2),evaluate_candidates.mjs(2),guard_selftest.sh(7),metadata_is_measured.mjs(8). Comments only.pattern_field_contract.json: 4 lines, all inside_commentstrings (the arrays at lines 3 and 24 and the_commentstring at line 100).Case numbers (
C01688,C01987,C02706,C02748), the fixture globs (gap_U1C_*,gap_UFEFF_*) and the reviewer's own case labelsX1andX2(incontrols/guard_selftest.shline 99 andcontrols/metadata_is_measured.mjsline 111, one pair each) are dropped on purpose, as in #40. The numbers, hashes, dates and counts that were measured stay. In the second commit, the comments that attributed a finding to a named seat now say it happened on that date without naming anyone, and the comment inprep_recompile.shthat quoted an old error now describes the error in plain words.Proof that no code changed
git diff --stat origin/main: 12 files changed, 67 insertions, 67 deletions.mainafter removing what is not code..mjs: full line//comments removed, the rest byte identical..sh: full line#comments removed, the rest byte identical..py: the parsed syntax tree with docstrings removed is identical.pattern_field_contract.json: the parsed document with every_commentkey removed is identical. All 12 pass on the branch head.py_compile,bash -n,node --checkand a JSON parse all pass on the changed files.node --test tests/*.test.mjs: 263 pass, 0 fail, the same asmain.controls/guard_selftest.shendsGUARD SELFTEST OKandcontrols/metadata_is_measured.mjsendsMETADATA CONTRACT OKover 137 cases, both run on the first commit. The second commit touches only comments in both files, which the stripped comparison above covers. The README is untouched, so the gates that read it are unaffected.Not changed, stated exactly
These still carry the reviewer's name, on purpose, because changing them changes run-time output, a file name or data:
printlines in the differential parity script named after the reviewer (lines 45, 88 and 128), plus its fixture paths (lines 27 to 29) and an environment variable name. Those are code.diemessage inprep_recompile_v058.sh(line 145) and the deploy checklist line in each ofprep_recompile.sh(line 228) andprep_recompile_v058.sh(line 190).controls/candidates/with the names inside them. AlsoRECOMPILE_CONTROLS_2026-09-20.md(recompile notes and history) andsrc/patterns.js.Review rounds are written as ordinal words, not digits ("the fifth round"), and that wording stays on 14 comment, docstring or
_commentlines:_source_parity.py164 and 243, the differential parity script 22 and 23,controls/_metadata_one_key.mjs40,controls/guard_selftest.sh72 and 99,controls/metadata_is_measured.mjs27, 53, 89 and 111,pattern_field_contract.json3 and 24, andprep_recompile.sh201. The claim in this description is about digits and names, not about ordinals. A comment is not run-time output, so no comment that names the reviewer or a seat is left on purpose; the retained mentions of the reviewer's name are the strings, paths and file names in the bullets above. The ordinal-word round references listed above are the only other comment wording kept on purpose. I searched the changed files for seat names, digit-numbered rounds and the reviewer's name. I did not certify that every pronoun that could refer to the reviewer is gone, because that is a judgment on prose and not something a search settles. The Worker and the scanner behave exactly as onmain.