fix: honor dtype/device in load_state_dict_hf - #993
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Early return skipped the conversion block so dtype= and device= were ignored.
1 task
Chessing234
force-pushed
the
fix/load-state-dict-hf-dtype-device
branch
from
August 5, 2026 10:24
531962d to
8c8046c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return torch.load(...)made the dtype/device conversion unreachable.state_dictthen convert before returning.Test plan
load_state_dict_hf(..., dtype=torch.float16)returns fp16 tensorsMade with Cursor