fix: harden Hugging Face config/weight loading helpers - #1007
Open
Chessing234 wants to merge 2 commits into
Open
fix: harden Hugging Face config/weight loading helpers#1007Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
Use context managers for config.json, raise FileNotFoundError when hub lookup fails, and pass weights_only=False on PyTorch 2.6+ for legacy bins.
Add CPU-only unit tests that mock cached_file without importing CUDA ops.
Chessing234
force-pushed
the
fix/hf-load-config-robustness
branch
from
August 5, 2026 10:23
fa4b39a to
cafb2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileNotFoundErrorwhenconfig.json/pytorch_model.binhub lookups fail.weights_only=Falseon PyTorch 2.6+ when loading legacy HF checkpoints.cached_file(no CUDA ops import).Complements #993 (dtype/device
load_state_dict_hffix) without overlapping that change.Test plan
pytest tests/test_hf_utils.pyMade with Cursor