Skip to content

[BUG] Gate open and remove buttons in relation tables on element permissions #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jonathon-Meney-Torq wants to merge 3 commits into
base: 2025.4
Choose a base branch
from
Open

[BUG] Gate open and remove buttons in relation tables on element permissions #3671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e34a4a6
Automatic frontend build
rjjackson22 May 28, 2026
0b749c8
Merge branch 'pimcore:2025.4' into 2025.4
Jonathon-Meney-Torq Jun 8, 2026
307302b
adds studio frontend changes for rendering buttons
Jonathon-Meney-Torq Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
46 changes: 26 additions & 20 deletions assets/js/src/core/components/many-to-many-relation/hooks/use-columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,26 +83,32 @@ export const useColumns = (props: UseColumnsProps): UseColumnsReturn => {
const rowIndex = info.row.index
const rowValue = info.row.original as DisplayManyToManyRelationValueItem

const hasAccess = rowValue.hasAccess !== false
const canEdit = rowValue.canEdit !== false

const buttons: ReactElement[] = []
buttons.push(
<Tooltip
key="open"
title={ t('open') }
>
<IconButton
icon={ { value: 'open-folder' } }
onClick={ async () => {
const typeValue = mapToElementType(rowValue.type)

!isUndefined(typeValue) && await openElement({
type: typeValue,
id: rowValue.id
})
} }
type="link"
/>
</Tooltip>
)

if (hasAccess) {
buttons.push(
<Tooltip
key="open"
title={ t('open') }
>
<IconButton
icon={ { value: 'open-folder' } }
onClick={ async () => {
const typeValue = mapToElementType(rowValue.type)

!isUndefined(typeValue) && await openElement({
type: typeValue,
id: rowValue.id
})
} }
type="link"
/>
</Tooltip>
)
}

if (props.assetInlineDownloadAllowed && rowValue.type === 'asset') {
buttons.push(
Expand All @@ -124,7 +130,7 @@ export const useColumns = (props: UseColumnsProps): UseColumnsReturn => {
)
}

if (props.disabled !== true) {
if (props.disabled !== true && canEdit) {
buttons.push(
<Tooltip
key="remove"
Expand Down
2 changes: 2 additions & 0 deletions assets/js/src/core/components/many-to-many-relation/hooks/use-value.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ export interface ManyToManyRelationValueItem {
subtype: string | null
fullPath: string
isPublished: boolean | null
hasAccess?: boolean
canEdit?: boolean
}

export interface DisplayManyToManyRelationValueItem extends ManyToManyRelationValueItem {
Expand Down
Loading
Loading