[BUG] Gate open and remove buttons in relation tables on element permissions#3671
Open
Jonathon-Meney-Torq wants to merge 3 commits into
Open
[BUG] Gate open and remove buttons in relation tables on element permissions#3671Jonathon-Meney-Torq wants to merge 3 commits into
Jonathon-Meney-Torq wants to merge 3 commits into
Conversation
Jonathon-Meney-Torq
requested review from
berfinyuksel and
bluvulture
as code owners
Jonathon-Meney-Torq
force-pushed
the
feature/relation-table-visibility
branch
from
4fa888e to
307302b
Compare
Jonathon-Meney-Torq
changed the title
|
Contributor
|
@Jonathon-Meney-Torq Nice, thanks a lot for the PR. The changes in package.json and package-lock.json seem to be unrelated and let the pipeline fail. Could you please revert them? If you could give me write access to the PR I can also check it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasAccessandcanEditoptional fields toManyToManyRelationValueIteminterfacehasAccess !== falseprops.disabled !== true && canEdit !== falsetruewhen absent, so all existing relation usages are unaffected