fix: allow dots in usernames for non-GitHub git providers#4343
Open
sanmaxdev wants to merge 5 commits into
Open
fix: allow dots in usernames for non-GitHub git providers#4343sanmaxdev wants to merge 5 commits into
sanmaxdev wants to merge 5 commits into
Conversation
Contributor
|
thanks for the fix. Can you please add a test in |
Author
|
Thanks — added the requested regression coverage in Verification:
|
The username validation regex was GitHub-specific and rejected usernames containing dots, which are valid on GitLab and other git providers. Updated the regex to accept dots and made the warning message provider-agnostic. Fixes nf-core#3655
sanmaxdev
force-pushed
the
fix/allow-dots-in-username
branch
from
0810a02 to
b85a7e3
Compare
Author
|
Added the requested test in Verification:
|
mashehu
requested changes
Jul 2, 2026
mashehu
left a comment
mashehu
left a comment
Contributor
There was a problem hiding this comment.
and please join the github org to have the CI run
| while self.author is None or not github_username_regex.match(self.author): | ||
| if self.author is not None and not github_username_regex.match(self.author): | ||
| log.warning("Does not look like a valid GitHub username (must start with an '@')!") | ||
| # Regex to validate username (GitHub, GitLab, and other git providers) |
Contributor
There was a problem hiding this comment.
Suggested change
| # Regex to validate username (GitHub, GitLab, and other git providers) | |
| # Regex to validate username (GitHub, GitLab, and other git-based code hosting services) |
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Author
|
Addressed both username validation review points and pushed the update. Verification:
|
Contributor
|
One more time: join the github org via the slack channel so the CI runs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_username()to accept dots (.)GitLab and other git providers allow dots in usernames, but the existing regex only accepted alphanumeric characters and hyphens. This blocked module creation for users with dotted usernames on those platforms.
Changes
nf_core/components/create.py: Modified regex to include.as a valid character in usernamesVerification
ruff format— 1 file already formattedruff check— All checks passed@user,@user.name,@first.last,@user-name.lastfrom nf_core.components.create import ComponentCreatepassesCloses #3655