Skip to content

CMR-11578 - Update Guava Dependency - #2521

Merged
jaortega527 merged 2 commits into
masterfrom
CMR-11578
Oct 21, 2026
Merged

jaortega527 merged 2 commits into
masterfrom
CMR-11578

Conversation

@jaortega527

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

Update the com.google.guava/guava dependency

What are the changes?

Added the com.google.guava/guava explicit declaration to the main project.clj to force transitive dependencies to explicitly use 33.7.2-jre.

What areas of the application does this impact?

  • search-app

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.73%. Comparing base (be66f88) to head (077f583).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2521       +/-   ##
===========================================
+ Coverage   27.44%   53.73%   +26.28%     
===========================================
  Files        1013     1073       +60     
  Lines       71474    74924     +3450     
  Branches     1195     2423     +1228     
===========================================
+ Hits        19619    40258    +20639     
+ Misses      50661    32385    -18276     
- Partials     1194     2281     +1087     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread project.clj Outdated

@jceaser jceaser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but I think we should talk to Erich about the tickets around swagger and decided to either drop it or improve it as it is now costing us time.

@jaortega527
jaortega527 force-pushed the CMR-11578 branch 2 times, most recently from 7dba88e to 31424bd Compare October 19, 2026 17:52
…t transitive dependencies will pull this version
…clj and added a metosin/scjsv exclusion to ring-swagger-ui in search-app/project.clj
@jaortega527
jaortega527 merged commit 29ea302 into master Oct 21, 2026
5 of 6 checks passed
@jaortega527
jaortega527 deleted the CMR-11578 branch October 21, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants