Repository navigation
NAT-490: Integrate DirectUpload standardization - #148
Merged
eugene-mux merged 5 commits intoAug 24, 2026
Merged
eugene-mux merged 5 commits into
eugene-mux merged 5 commits into
Conversation
eugene-mux
marked this pull request as ready for review
August 19, 2026 21:41
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 41af308. Configure here.
daytime-em
approved these changes
Aug 21, 2026
eugene-mux
merged commit Aug 24, 2026
8be8a71
into
feature/nat-335-hevc-standard-ingest
6 checks passed
eugene-mux
added a commit
that referenced
this pull request
Sep 16, 2026
* NAT-481: Add HEVC/4K public API and lock compatibility behavior (#135) * NAT-481: Add HEVC and 4K public API * Handle missing iOS simulators * NAT-482: Add standard input policy evaluator (#136) * NAT-484: Inspect standard input metadata (#137) * NAT-485: Inspect GOP and keyframe characteristics (#139) * NAT-485: Inspect GOP and keyframe characteristics * NAT-485: Synchronize inspection cancellation * NAT-486: Plan and validate input standardization (#141) * NAT-486: Plan and validate input standardization * Remove ticket references from validation code * NAT-486: Fix aspect ratio alignment tolerance * Serialize upload cancellation and transport start * Refine cancellation lifecycle synchronization * Isolate upload lifecycle attempts * Scope inspection cancellation to upload attempts * NAT-487: Build the codec-preserving reader/writer conversion pipeline (#143) * NAT-487: Build codec-preserving conversion pipeline * Coordinate conversion cancellation and failures * Modernize input standardization concurrency * Scope standardization cancellation to attempts * Remove ticket references from test fixtures * Improve conversion cancellation coverage * NAT-488: Add Standard Input encoder controls (#145) * NAT-488: Add Standard Input encoder controls * Fix edit-list inspection and simulator conversion * NAT-489: Add HDR tone mapping (#146) * NAT-490: Integrate DirectUpload standardization (#148) * NAT-490: Integrate DirectUpload standardization * Stabilize direct upload fallback test * Make direct upload lifecycle tests deterministic * Isolate asynchronous direct upload tests * Clean up standardized output after upload failure * NAT-491: Add standardization diagnostic logging (#149) * NAT-492: Fix acceptance-discovered timeline and pause defects (#151) * NAT-492: Fix timeline validation and preparation pause * NAT-492: Archive external fixture test hooks * Fix deferred inspection test synchronization * NAT-335: Restart uploads when forceRestart is requested * NAT-335: Isolate forced restarts from shared upload workers * NAT-493: Update README and sample app for HEVC and 4K (#153) * NAT-493: Update README and sample app * NAT-493: Update DocC API reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
DirectUploadImpact
Eligible inputs can now pass through, convert with the planned codec/HDR behavior, or fall back to the original upload according to the existing confirmation handler contract. Generated output is re-inspected and validated before transport. Cancellation cannot advance a stale attempt or delete files outside the configured temporary-output provider.
Note
High Risk
Changes the core upload preparation path, concurrency model, and media I/O/cancellation behavior; incorrect lifecycle or validation could upload wrong files or leak/delete temp outputs.
Overview
DirectUpload preparation is reworked around Standard Input planning instead of separate rescale-only and non-standard conversion branches. After inspection, the SDK probes device/source capabilities, runs
StandardInputPlanner, then either uploads the original, converts with an explicitStandardInputConversion, or fails into the existingnonStandardInputHandlerfallback path.Conversion always receives a non-optional conversion plan; generated files are re-inspected and validated with
StandardInputOutputValidator(including new timeline facts fromStandardInputTimelineInspector) before transport. Temporary storage preflight reserves space and owned standardized outputs are deleted on cancel, validation failure, or transport failure.Concurrency moves from locks to actors for inspection operations/registry and preparation lifecycle, plus an ordered
DirectUploadLifecycleCommandQueueandDirectUploadTransportCommitCoordinatorso start/cancel/commit stay serialized and URL de-duplication stays atomic.AVFoundationUploadInputInspectorand sample/timeline readers are async, with reader cancellation coordinated on the consuming task rather than concurrentcancelReading().Reviewed by Cursor Bugbot for commit c47e2ff. Bugbot is set up for automated code reviews on this repo. Configure here.