Skip to content

NAT-491: Add standardization diagnostic logging - #149

Merged
eugene-mux merged 1 commit into
em/nat-490-direct-upload-integrationfrom
em/nat-491-standardization-diagnostic-logging
Aug 24, 2026
Merged

eugene-mux merged 1 commit into
em/nat-490-direct-upload-integrationfrom
em/nat-491-standardization-diagnostic-logging

Conversation

@eugene-mux

@eugene-mux eugene-mux commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add structured SDKLogger diagnostics for source and generated-output inspection, selected plans, codecs, resolution tier, HDR decisions, conversion duration, output validation, and categorized failures
  • distinguish intentional HLG and PQ preservation, including the compatible server-processing decision, without emitting failure diagnostics
  • keep publicly rendered diagnostics credential-safe through closed typed payloads; never render raw errors, URLs, file paths, headers, tokens, or credentials
  • preserve existing lifecycle, fallback, cancellation, stale-attempt, and temporary-output ownership behavior

Note

Low Risk
Observability-only changes along the existing preparation path; upload lifecycle, fallbacks, and cancellation behavior are unchanged aside from extra async log calls.

Overview
Adds structured OSLog diagnostics across the input standardization pipeline, replacing the ad-hoc debug plan log with injectable StandardizationDiagnosticLogging.

DirectUpload now emits typed events for source/generated inspection, plan selection (codec, resolution tier, HDR handling/decisions), conversion completion with duration, output validation, and categorized failures (inspection, capability, storage, conversion, output inspection/validation). Intentional HLG/PQ preservation is reflected in plan/HDR fields without standardization_failure events.

Diagnostics are built from closed vocabularies and sanitized media facts only—no raw errors, URLs, paths, or credentials in public log lines. Tests use a recording logger and assert expected fields plus that sensitive strings stay out of messages.

Reviewed by Cursor Bugbot for commit 947a85c. Bugbot is set up for automated code reviews on this repo. Configure here.

@eugene-mux
eugene-mux marked this pull request as ready for review August 19, 2026 23:39
@eugene-mux
eugene-mux requested a review from a team as a code owner August 19, 2026 23:39
@eugene-mux
eugene-mux merged commit c2f61a3 into feature/nat-335-hevc-standard-ingest Aug 24, 2026
8 checks passed
@eugene-mux
eugene-mux deleted the em/nat-491-standardization-diagnostic-logging branch August 24, 2026 21:29
eugene-mux added a commit that referenced this pull request Sep 16, 2026
* NAT-481: Add HEVC/4K public API and lock compatibility behavior (#135)

* NAT-481: Add HEVC and 4K public API

* Handle missing iOS simulators

* NAT-482: Add standard input policy evaluator (#136)

* NAT-484: Inspect standard input metadata (#137)

* NAT-485: Inspect GOP and keyframe characteristics (#139)

* NAT-485: Inspect GOP and keyframe characteristics

* NAT-485: Synchronize inspection cancellation

* NAT-486: Plan and validate input standardization (#141)

* NAT-486: Plan and validate input standardization

* Remove ticket references from validation code

* NAT-486: Fix aspect ratio alignment tolerance

* Serialize upload cancellation and transport start

* Refine cancellation lifecycle synchronization

* Isolate upload lifecycle attempts

* Scope inspection cancellation to upload attempts

* NAT-487: Build the codec-preserving reader/writer conversion pipeline (#143)

* NAT-487: Build codec-preserving conversion pipeline

* Coordinate conversion cancellation and failures

* Modernize input standardization concurrency

* Scope standardization cancellation to attempts

* Remove ticket references from test fixtures

* Improve conversion cancellation coverage

* NAT-488: Add Standard Input encoder controls (#145)

* NAT-488: Add Standard Input encoder controls

* Fix edit-list inspection and simulator conversion

* NAT-489: Add HDR tone mapping (#146)

* NAT-490: Integrate DirectUpload standardization (#148)

* NAT-490: Integrate DirectUpload standardization

* Stabilize direct upload fallback test

* Make direct upload lifecycle tests deterministic

* Isolate asynchronous direct upload tests

* Clean up standardized output after upload failure

* NAT-491: Add standardization diagnostic logging (#149)

* NAT-492: Fix acceptance-discovered timeline and pause defects (#151)

* NAT-492: Fix timeline validation and preparation pause

* NAT-492: Archive external fixture test hooks

* Fix deferred inspection test synchronization

* NAT-335: Restart uploads when forceRestart is requested

* NAT-335: Isolate forced restarts from shared upload workers

* NAT-493: Update README and sample app for HEVC and 4K (#153)

* NAT-493: Update README and sample app

* NAT-493: Update DocC API reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants