Skip to content

🐛 Make QTensor shrinking sparse and atomic - #2295

Merged
simon1hofmann merged 3 commits into
mainfrom
codex/2255-qtensor-shrink-contracts
Aug 31, 2026
Merged

🐛 Make QTensor shrinking sparse and atomic#2295
simon1hofmann merged 3 commits into
mainfrom
codex/2255-qtensor-shrink-contracts

Conversation

@simon1hofmann

@simon1hofmann simon1hofmann commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

🤖 AI text below 🤖

Description

Makes qtensor-shrink-to-fit safe for very large declared tensors and
unsupported non-linear tensor chains.

The rewrite previously allocated dense helper vectors proportional to the
declared tensor size and asserted that every tensor value had exactly one use.
It now builds a sparse, read-only access plan, validates the complete chain
before rewriting, and commits the compact replacement only after planning
succeeds.

This is one focused replacement for draft PR #2287 and addresses part of #2255.

Validation

  • full QTensor transform suite — 3/3 passed
  • uvx nox -s lint — passed
  • git diff --check — passed

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

AI assistance disclosure: Codex extracted and simplified this focused change
from the authorized #2255 audit, validated it, and drafted this description.

Assisted-by: GPT-5.6 Sol via Codex
@simon1hofmann simon1hofmann self-assigned this Aug 31, 2026
@simon1hofmann simon1hofmann added c++ Anything related to C++ code code quality Code quality improvements fix Fix for something that isn't working MLIR Anything related to MLIR skip-changelog Changes that do not need to show up in the changelog labels Aug 31, 2026

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM except for one small detail

Comment thread mlir/lib/Dialect/QTensor/Transforms/ShrinkRegisters.cpp Outdated
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Assisted-by: GPT-5.6 Sol via Codex
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Assisted-by: GPT-5.6 Sol via Codex
@simon1hofmann
simon1hofmann enabled auto-merge (squash) August 31, 2026 20:57
@simon1hofmann
simon1hofmann merged commit 3fa6800 into main Aug 31, 2026
26 checks passed
@simon1hofmann
simon1hofmann deleted the codex/2255-qtensor-shrink-contracts branch August 31, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code code quality Code quality improvements fix Fix for something that isn't working MLIR Anything related to MLIR skip-changelog Changes that do not need to show up in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants