🐛 Make QTensor shrinking sparse and atomic - #2295
Merged
Merged
Conversation
Assisted-by: GPT-5.6 Sol via Codex
burgholzer
approved these changes
Aug 31, 2026
burgholzer
left a comment
Member
There was a problem hiding this comment.
This LGTM except for one small detail
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Assisted-by: GPT-5.6 Sol via Codex
Contributor
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Assisted-by: GPT-5.6 Sol via Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Makes
qtensor-shrink-to-fitsafe for very large declared tensors andunsupported non-linear tensor chains.
The rewrite previously allocated dense helper vectors proportional to the
declared tensor size and asserted that every tensor value had exactly one use.
It now builds a sparse, read-only access plan, validates the complete chain
before rewriting, and commits the compact replacement only after planning
succeeds.
This is one focused replacement for draft PR #2287 and addresses part of #2255.
Validation
uvx nox -s lint— passedgit diff --check— passedChecklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).AI assistance disclosure: Codex extracted and simplified this focused change
from the authorized #2255 audit, validated it, and drafted this description.