🐛 Reject nonlinear QTensor shrink chains safely - #2303
Closed
simon1hofmann wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
This feels like a fix at the wrong level. QTensor, by-definition, is a linear type. Any violation of that constraint already constitutes an invalid program. Please revisit. |
Contributor
Author
|
🤖 AI text below 🤖 Agreed. This follow-up reintroduced the same one-use guard and invalid nonlinear regression that were removed from #2295 after review. QTensor linearity is the owning contract, and qco::verifyLinearity already requires each tensor value to have exactly one use. I am closing this PR as redundant. |
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Summary
Follow-up to #2295 and part of #2255.
Validation
AI assistance: Codex extracted the minimal follow-up from the contract audit branch and ran the listed validation.
Checklist
I have updated the documentation to reflect these changes.(Not applicable: no user-facing documentation change is needed.)I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.(Not applicable: this focused fix is labeled skip-changelog.)I have added migration instructions to the upgrade guide (if needed).(Not needed.)If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).