Repository navigation
ci(sibling-pins): keep PR text edits from blocking merges - #2558
Merged
Merged
Conversation
Editing a pull request's title or description started a new run of this workflow, and that run skipped its job. The skipped job did not report under the required check name, and a passing run from before the edit no longer satisfied the check. The pull request then showed the check as "Expected" and could not merge until someone pushed a new commit. Keeping the skip with a fixed job name would not be safe. GitHub treats a skipped required check as passing, so a text edit could hide a failing pin. Running this short check on every edit keeps the required result accurate. Generated with Claude Code (claude-opus-5-5) Co-authored-by: Claude Code <noreply@anthropic.com>
roborev: Combined Review (
|
cpcloud
pushed a commit
to kenn-io/actions
that referenced
this pull request
Nov 2, 2026
The README now warns repos adopting the `Sibling pins on main` required check to keep its `edited` trigger and never skip the job with `if:`. A skipped job reports under its raw `name:` expression, which blocked merges in 13 repos until kenn-io/agentsview#2558 and its siblings reverted it. Co-authored-by: Rod Boev <rodboev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Editing a PR's title or description blocks the merge: the required
Sibling pins on maincheck goes back to "Expected", even after it passed. The check now runs on text edits again, so each edit reports a real result under the required name.Reviewer notes
main, but that path is untested.Generated with Claude Code (claude-opus-5-5)