Repository navigation
docs(sibling-pins): warn against skipping the check on PR edits - #16
Merged
Merged
Conversation
Skipping the job on title or description edits blocked every merge in 13 repos. GitHub posted the skipped job under its unevaluated name expression, so the required check named "Sibling pins on main" never reported and the merge button stayed disabled. Consumers copy this README's workflow, so the warning sits next to the rule about the job name that it breaks.
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README now warns repos adopting the
Sibling pins on mainrequired check to keep itseditedtrigger and never skip the job withif:. A skipped job reports under its rawname:expression, which blocked merges in 13 repos until kenn-io/agentsview#2558 and its siblings reverted it.