Repository navigation
Override the wasm lock's ws to 8.22.0 - #135
Merged
Merged
Conversation
Ktor's JS/wasm client pins ws 8.20.1 (still on Ktor main), which a ws security advisory covers (>= 8.0.0 < 8.21.0). Dependabot's security update kept failing because kotlin-js-store/wasm has a lockfile but no package.json. The browser app never loads ws, but add a wasm yarn resolution so the lock carries a fixed release; drop it once Ktor bumps ws. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012JqiL2Tbg2oz8bvJYsmpxH
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kotlin-js-store/wasm/yarn.lockpinsws@8.20.1, which is in the range of awssecurity advisory (>= 8.0.0 < 8.21.0). Dependabot can't fix it, because that folder has a lockfile but nopackage.jsonktor-client-core3.6.0, the latest release, declares the npm dependency"ws": "8.20.1"for its Node.js WebSocket support. Ktor'smainstill pins the same version. The browser web app never loadsws, since it uses the browser's own WebSocket, so the risk was nil in practicebuild.gradle.ktsaddsWasmYarnRootExtension.resolution("ws", "8.22.0")(the latestws), and the lock was regenerated, so it now resolveswsto 8.22.0. A comment says to drop the override once Ktor bumpswsitselfTest plan
kotlinWasmUpgradeYarnLock: the generatedbuild/wasm/package.jsonhasresolutions: {ws: 8.22.0}, and the lock resolveswsto 8.22.0:webApp:wasmJsBrowserDistributionsucceeds, and the lock check accepts the new lock🤖 Generated with Claude Code
https://claude.ai/code/session_012JqiL2Tbg2oz8bvJYsmpxH