Repository navigation
Time out hung backend requests so the retry can take over - #136
Merged
Merged
Conversation
The HTTP client had no timeout, so a request hanging on a Cloud Run cold start waited for the platform default (60s on iOS) before `retrying` could try again. The iOS Maestro flow then saw the Routes spinner for its whole 30s wait and failed. Add a 20s request / 10s connect timeout (responses are small and normally sub-second; the live bus feed ~4s), and give the flow's route-list wait 60s to cover a cold start plus one retry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012JqiL2Tbg2oz8bvJYsmpxH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maestro-debug-iosscreenshot from Override the wasm lock's ws to 8.22.0 #135's first run shows the Routes screen still spinning after the 30s wait. The backend and route data were fine (routes.jsonin about 0.1s), and iOS CI onmainpassesHttpClienthas no timeout.getRoutes()already goes throughretrying(3 attempts), but a request that hangs never fails, for example on a Cloud Run cold start. It waits out the platform default, 60s on iOS, before the retry can startinstall(HttpTimeout) { requestTimeoutMillis = 20_000; connectTimeoutMillis = 10_000 }. Every response is small:routes.jsonis 555 B,stops.json74 KB and a route about 44 KB, all under 0.2s warm. The livebus.jsonis about 4s, so 20s leaves headroomHttpClient, so they're unaffectedTest plan
:shared:jvmTestand:shared:iosSimulatorArm64Test(119 tests) pass, and the Android, iOS (compileKotlinIosArm64) and wasm builds succeed🤖 Generated with Claude Code
https://claude.ai/code/session_012JqiL2Tbg2oz8bvJYsmpxH