Skip to content

Fix the route map crash with older Play services; make Maestro catch it #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joreilly merged 2 commits into from
Oct 17, 2026
+11 −1
Merged

Fix the route map crash with older Play services; make Maestro catch it #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a25ae84
Maestro: fail if the app dies after the route map renders; keep logcat
joreilly Oct 17, 2026
11fc7e2
Fix the route map crash with older Google Play services
joreilly Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
disable-animations: true
script: |
adb install androidApp/build/outputs/apk/debug/androidApp-debug.apk
maestro test --debug-output maestro-debug -e APP_ID=dev.johnoreilly.galwaybus maestro/GalwayBus.flow
maestro test --debug-output maestro-debug -e APP_ID=dev.johnoreilly.galwaybus maestro/GalwayBus.flow; status=$?; mkdir -p maestro-debug; adb logcat -d > maestro-debug/logcat.txt; exit $status

# takeScreenshot output: Maestro saves it under --debug-output's hidden .maestro directory
- uses: actions/upload-artifact@v7
Expand Down
6 changes: 6 additions & 0 deletions androidApp/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
<meta-data
android:name="com.google.android.geo.API_KEY"
android:value="${MAPS_API_KEY}"/>
<!-- Older Google Play services' Maps module uses the Apache HTTP client, which apps
targeting API 28+ must opt into or the map crashes (NoClassDefFoundError:
org/apache/http/ProtocolVersion) -->
<uses-library
android:name="org.apache.http.legacy"
android:required="false"/>
<activity
android:exported="true"
android:name=".MainActivity">
Expand Down
4 changes: 4 additions & 0 deletions maestro/GalwayBus.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,7 @@ appId: ${APP_ID}
visible: "Updated.*"
timeout: 30000
- takeScreenshot: GalwayBus
# Still showing after the map has had time to render (a crash there would otherwise go unnoticed)
- waitForAnimationToEnd:
timeout: 5000
- assertVisible: "Route 402"
Loading