Repository navigation
Fix the route map crash with older Play services; make Maestro catch it - #132
Merged
Merged
Conversation
On CI the app disappeared right after the map step, so the screenshot showed the home screen while the job passed. Re-check the screen after the screenshot, and save logcat with the debug output to see why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G317KNXo9kZndPaSEtMCuG
The Maps module in older Play services (22.50 on the CI emulator) uses the Apache HTTP client, which apps targeting API 28+ must declare, so the map crashed with NoClassDefFoundError: org/apache/http/ProtocolVersion. Real devices with older Play services would hit the same crash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G317KNXo9kZndPaSEtMCuG
joreilly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google_apisAPI 32 emulator. Logcat:NoClassDefFoundError: Failed resolution of: Lorg/apache/http/ProtocolVersion;fromcom.google.android.gms.dynamite_mapsdynamite@22.50.14.The Maps module in older Google Play services uses the Apache HTTP client, which apps targeting API 28+ must declare. Adds
<uses-library android:name="org.apache.http.legacy" android:required="false"/>, Google's documented fix. Real devices with older Play services would crash the same way; newer Play services (as on my local emulator) don't need it.adb logcat -dintomaestro-debug/, which uploads on failure.Test plan
maestrojob fails, and logcat shows the crash aboveuses-libraryis in the built APK's manifest, and the flow passes locally (API 37 emulator)maestrojob green, and the Android screenshot shows the route map🤖 Generated with Claude Code
https://claude.ai/code/session_01G317KNXo9kZndPaSEtMCuG