Repository navigation
fix(lens): 3.5.1 review fixes - #35
Merged
Merged
Conversation
…fused at runtime, JSON re-check selects - toLensSelect selects a bridged source's local reads (and each bridge's local on key) as fetch-only columns, so materializeSources over its rows + the far side answers it. - A label/groupBy across a to-many relation is refused by toSourceQueries and materializeSources too: one shared toOnePathError check, so validateNarrowing is ok exactly when no posture refuses. - A re-check reading into a Json column selects the column whole; SQL refusal messages name the real reason. SourcePrismaQuery.steps is present for a column reference too. - Count operators across a bridge say so. - README snippets destructure query.prisma and run steps through executePrismaPlan (tested against the rails harness); orderRecords notes JS code-unit string order. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the adversarial review of 3.5.0 (TDD; tests in
test/review.351.test.ts).materializeSourcesover its rows + far side threwUsageError: lacks 'age'forany: [age > 35, crm:Profile.tier = gold]withagehidden. It now selects the source's local reads (a read across the bridge → that bridge's localonkey) as fetch-only columns; a viewer'sprojectRowsdrops them (tested).prisma[query.model].findMany(query.prisma)is rejected by Prisma and ignoredsteps. Both source-query snippets now destructure and runstepsthroughexecutePrismaPlan; a test runs that shape against the rails harness (plain, bridged, count step, column ref). This surfaced thatSourcePrismaQuery.stepswas dropped for a column-reference where (unresolved__field), now fixed:stepsis present whenever the where needsexecutePrismaPlan.toSourceQueries/materializeSourcesran.toOnePathErroris now the single check used by validation and the source plans (inspect mode included); test asserts validateNarrowing ok ⇔ no posture refuses.meta: true), so SQL no longer refuses a local JSON read; the SQL refusal message names the real reason. Count operators across a bridge now say "aren't supported across a bridge".CHANGELOG 3.5.1, version bump. No release/tag (train publishes).
🤖 Generated with Claude Code