Repository navigation
fix(validate): count operators need condition and count on every target (3.5.1) - #36
Merged
Merged
Conversation
…rget (3.5.1) validateRule required them only for `check`; toPrisma's count step (and toSql, which refuses the operator) reject a count operator without them, so validateNarrowing passed a source that toSourceQueries refused. Folded into the unreleased 3.5.1 entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35, folded into the unreleased 3.5.1 entry (no version change).
validateRulerequired a count operator'scondition(andcount) only for thechecktarget.toPrisma's count step throws without either, andtoSqlrefuses the operator. So{ field: 'posts', arrayOperator: 'atLeast', count: 2 }validated fortoPrisma, and a lens source holding it passedvalidateNarrowingwhiletoSourceQueriesrefused it. Both are now required on every target (missing_condition/missing_count).Tests (written first, failing before the fix):
validateRulefor check, toPrisma and toSql refuses a missing condition and a missing count.validateNarrowingandtoSourceQueriesagree for both sources.The stale
validateRule.test.tscase "allows missing count for toPrisma" now asserts the refusal.Full
bun run check: 2670 pass / 0 fail.🤖 Generated with Claude Code