Skip to content

fix for pow(0,0) in mom counter #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdziekan merged 2 commits into from
Aug 25, 2026
+3 −1
Merged

fix for pow(0,0) in mom counter #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
018d46e
get attr: if uknown name passed, print it in error message
pdziekan Aug 24, 2026
ce86264
moms counter: avoid calling pow in 0-th power (due to ambiguities of …
pdziekan Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/impl/diagnose_SD_attributes/particles_impl_fill_outbuf.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace libcloudphxx
{
const std::set<std::string> attr_names = {"rw2", "rd3", "kappa", "rd2_insol", "T_freeze", "ice_a", "ice_c", "ice_rho", "x", "y", "z"}; // TODO implement "n" - it is n_t type and others are real_t
if (std::find(std::begin(attr_names), std::end(attr_names), name) == std::end(attr_names))
throw std::runtime_error("Unknown attribute name passed to get_attr.");
throw std::runtime_error("Unknown attribute name '" + name + "' passed to get_attr.");

if (!opts_init.ice_switch &&
(name == "ice_a" || name == "ice_c" || name == "ice_rho" || name == "rd2_insol" || name == "T_freeze"))
Expand Down
2 changes: 2 additions & 0 deletions src/impl/diagnose_SD_attributes/particles_impl_moms.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,8 @@ namespace libcloudphxx
#endif
const real_t n = thrust::get<0>(tpl);
const real_t x = thrust::get<1>(tpl);
if(xp == 0)
return n;
#if !defined(NDEBUG)
real_t res;
if(x >= 0)
Expand Down
Loading