fix for pow(0,0) in mom counter - #499
Open
pdziekan wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes zeroth-moment handling for zero-valued attributes and improves unknown-attribute diagnostics.
Changes:
- Avoids evaluating
pow(x, 0). - Includes invalid attribute names in error messages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
src/impl/diagnose_SD_attributes/particles_impl_moms.ipp |
Handles zero-order moments directly. |
src/impl/diagnose_SD_attributes/particles_impl_fill_outbuf.ipp |
Improves unknown-attribute error details. |
Suppressed comments (1)
src/impl/diagnose_SD_attributes/particles_impl_moms.ipp:254
- Please add a regression test that initializes a diagnosed attribute to zero and calls a zeroth moment (for example,
diag_up_mom(0)). The existing tests exercise zeroth moments only with positive radii or other nonzero values, so they would not catch thepow(0,0)failure this branch is intended to prevent; covering the CUDA backend would be valuable as well.
if(xp == 0)
return n;
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.