Repository navigation
fix: preserve query and dashboard tag filters in URLs - #7905
Merged
Merged
Conversation
Synchronize selected tags with repeated tags query parameters and restore list state when opening shared links or navigating browser history. Cover URL restoration, multi-selection, search, sorting, pagination, and listener cleanup. Fixes getredash#3197
[Medium impact] The PR appears safe to merge; the previous search-text issue is fixed and no new blocking issues were found. SummaryThe PR keeps query and dashboard tag selections in repeated
|
Cancel delayed and queued searches before restoring URL state and when unmounting, so stale search input cannot overwrite navigation. Ignore sort direction for relevance-ordered results and preserve the prior sort field and direction when restoring search state. Add regression coverage for browser history, stale responses, cleanup, and sort restoration.
poplav
force-pushed
the
fix/tag-filter-urls
branch
from
November 2, 2026 20:15
5f9e033 to
358eae8
Compare
Contributor
Author
|
Addressed greptile comments. I see on one test failing at https://github.com/getredash/redash/actions/runs/41517621549/job/125525458277?pr=7905 the e2e tests, but pretty sure it's something flaky/sensitive with the tests and restart may resolve it. |
Member
|
Thanks, @poplav . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize selected tags with repeated tags query parameters and restore list state when opening shared links or navigating browser history.
Document shareable filters and cover URL restoration, multi-selection, search, sorting, pagination, and listener cleanup.
Fixes #3197
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)