ci: Inline Cloudflare Pages project name - #455
Conversation
Replace vars.CLOUDFLARE_PROJECT_NAME with the literal project name the workflow already deploys to. The variable was scoped to a single environment, so it silently resolves to empty in any other environment. Matches facioquo/schemas deploy.yml.
|
|
FaciōQuōqa Mage automatic code review is disabled in your 
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Select the environment from github.ref rather than the event type, so a workflow_dispatch off a feature branch resolves to preview instead of production. Production is only reached from the default branch.
1 participant
Org-wide consistency cleanup: retire
vars.CLOUDFLARE_PROJECT_NAMEin favour of the literal project name, matching facioquo/schemasdeploy.yml(--project-name=schemas).Why: the variable was defined only at environment scope, so it resolves to an empty string in any job that runs under a different environment — and an empty
--project-namefails at deploy time rather than at lint time. Two sibling repos hit exactly this while adding PR preview deployments. The value is a stable, non-secret identifier, so the indirection buys nothing.No change to what gets deployed or where — the inlined value is the same one the environment variable already supplied.
Follow-up
Once this merges, the now-unused
CLOUDFLARE_PROJECT_NAMEvariable can be deleted from this repo's environment settings. It has no other references in the repo.