fix: Repair CI — ruff format drift and broken .NET doc image links - #456
Conversation
Ruff 0.16 formats Python code blocks inside Markdown, so the docs examples began failing 'ruff format --check' without any change to the repo. Reformats the 23 affected files; changes are confined to fenced python blocks.
|
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Stock.Indicators repo moved to facioquo/stock-indicators-dotnet and v3.0.0 migrated its docs to VitePress, deleting docs/assets/charts. raw.githubusercontent does not follow repo renames, so all 82 chart images plus examples.webp returned 404 and HTML-Proofer failed. Pin to d0b99458, the last commit carrying the full PascalCase set.
Fixes both CI failures in this repo. They are unrelated to each other and neither was caused by a code change here — both are external drift that turned every PR red.
1.
lint-and-test→ Ruff format checkrequirements-test.txtpins noruffversion, so CI installs the newest release. Ruff 0.16 formats Python code blocks embedded in Markdown, pullingdocs/**/*.mdintoruff format --checkfor the first time. 23 doc files had never been formatted.Verified against the version CI uses (
ruff 0.16.0):23 files would be reformatted→304 files already formatted.ruff check .passed throughout — lint was never the problem.Every edit is inside a fenced
```pythonblock; no prose, front matter, or fence lines touched. Several are real improvements to the examples:indicators.get_doji(quotes);→indicators.get_doji(quotes)get_kama(quotes, 10,2,30)→get_kama(quotes, 10, 2, 30)class, and[ x for ... ]→[x for ...]2.
test→ Test for broken URLs (83 HTML-Proofer failures)DaveSkender/Stock.Indicatorswas renamed tofacioquo/stock-indicators-dotnet, and its v3.0.0 VitePress migration (896ae089) deleteddocs/assets/charts/, renaming the surviving images to kebab-case.raw.githubusercontent.comdoes not follow repo renames, so all 82 chart images plusexamples.webpbegan returning 404.Repointed
site.dotnet.chartstod0b99458— the last commit carrying the complete PascalCase set. All 82 URLs plusexamples.webpverified returning HTTP 200.A pinned commit rather than
mainis deliberate: four referenced images (AdIndex,Correlation,HeikinAshi,StdDevChannelsFull) have no equivalent in the current tree, so pointing at today's kebab-case assets would still leave four broken links and require deciding what to show instead. That is a docs-content call, not a CI fix. Also updated the stalerepo/srcURLs to the new org.Follow-ups worth considering
ruff(with Dependabot) or excludedocs/**from formatting.github.com/DaveSkender/Stock.Indicators/discussionsincontributing.mdare left alone —github.comdoes follow renames, so they resolve and pass.