Repository navigation
Conversation
github-actions
Bot
added
c-update
Collaborator
File
|
This was referenced Oct 10, 2026
Marchhill
added a commit
to Marchhill/EIPs
that referenced
this pull request
Oct 10, 2026
Relies on discard_dependencies from ethereum#12473.
5 tasks done
| - `proofs` = list of individual proof byte strings corresponding to each dependency in `deps`, in order | ||
| - `stark_proof` = a single recursive STARK proving validity of all deps, with public input `get_deps_hash(deps)` | ||
|
|
||
| A wrapper whose `deps` is empty must use mode 0, with an empty `proofs` list. |
Contributor
There was a problem hiding this comment.
Can deps be empty here? A dependency frame needs at least one triple.
| 4. The total number of deps is `<= MAX_DEPS_PER_AGGREGATE`, and the number with `LEANSTARK_SCHEME` is `<= MAX_LEANSTARK_DEPS_PER_AGGREGATE` | ||
|
|
||
| Each wrapper contains exactly one STARK in mode 1, and one STARK per leanSTARK dependency in mode 0. Per `AGGREGATION_INTERVAL`, a mempool node broadcasts exactly one wrapper containing all currently active transactions, with exactly one STARK covering all their dependencies. | ||
| Full wrapper validation in either mode requires resolving transaction hashes. After validation, admission is evaluated per transaction: rejection for current state, fees or local pool policy does not invalidate the proof or require rejecting other transactions. |
Contributor
There was a problem hiding this comment.
What does a node do when a hash entry doesn't resolve?
Marchhill
force-pushed
the
eip8288-bounded-batches
branch
from
October 14, 2026 20:12
25f340f to
cd84517
Compare
# Conflicts: # EIPS/eip-8288.md
…cache a recommendation
Marchhill
changed the title
…s by verification kind and verifier
manusw7
reviewed
Oct 20, 2026
There was a problem hiding this comment.
The hash-only wrapper and the 96-byte scheme-bound digest read much cleaner. A few things:
- Unresolved hashes are free. An unresolved hash leaves the wrapper "incomplete, not invalid", and running out of budget abandons recovery without a penalty. A peer can send wrappers with self-signed sigs and random tx hashes and fill the recovery budget at almost no cost. Can we make non-delivery of listed envelopes a peer fault (or point normatively to EIP-8437 if that's where it lives), and cap incomplete wrappers per peer?
- No canonical leanSPHINCS witness length. Padded witnesses could be accepted by one verifier and rejected by another, and they also miss the
keccak256(witness)cache. Fixing the length and rejecting others before verification closes both. - Missing
slot_number. The target fork estimate has no rule for a parent or head withoutslot_number(EIP-7843 activating in the same fork). Falling back to the head's fork in that case seems enough. - "The transport's grace window" isn't defined or referenced anywhere.
- FOCIL section still has the proof inline (
recursive_stark = [stark_proof, deps_hash]), which clashes with the header commitment and can't fit the 8 KiB IL limit. Mark it superseded by #12475? - Zero
data_hash. This branch dropped "an all-zerodata_hashis reserved", which #12475 still has. I think it should stay.
Marchhill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #12590 for wrapper encoding and validation. Proof-in-body changes are covered by #12479; FOCIL interaction remains in #12475 and networking in #12423.