Disable treatPhpDocTypesAsCertain phpstan option and clean up baseline - #12631
Merged
greg0ire merged 1 commit intoSep 23, 2026
Merged
Conversation
whataboutpereira
force-pushed
the
treat-php-doc-types-as-certain
branch
from
September 22, 2026 15:00
30510c0 to
1c832fe
Compare
greg0ire
reviewed
Sep 22, 2026
…ine and @PHPStan-Ignore This will allow for more defensive checks such as using narrower phpstan parameters that are also checked during runtime, without having to add phpstan ignores. Suggested in #12626 (comment)
whataboutpereira
force-pushed
the
treat-php-doc-types-as-certain
branch
from
September 22, 2026 17:37
1c832fe to
eb52c5e
Compare
greg0ire
approved these changes
Sep 22, 2026
Member
|
Thanks @whataboutpereira ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested in #12626 (comment)
This will allow for more defensive checks such as using narrower phpstan parameters that are also checked during runtime, without having to add phpstan ignores.