Merge release 3.7.2 into 3.8.x - #12632
Merged
Merged
Conversation
Github UI has no pull request chooser, so it is unclear what uses these templates. Besides, the branch number inside "New_feature.md" are grossly outdated. This leads to bugfix PRs being wrongly templated as improvements. Let us remove the templates, and consider promoting e.g. https://github.com/doctrine/dbal/blob/4.4.x/.github/PULL_REQUEST_TEMPLATE.md as a global template if we feel they are really needed.
…t is not a mapped entity
Remove pull request templates
…t-for-native-lazy-objects-no-op Fix no-op for initializeObject() and isUninitializedObject() when object is not a mapped entity
CursorWalker named them after the ordered path expressions, as <identificationVariable>_<field>_<index>, and bound them with setParameter(): a query binding its own :p_id_0 while ordering by p.id had that value silently replaced by the cursor value, and returned the wrong rows from the second page on. The names are internal, regenerated on every parse and absent from the Cursor payload, so they can be namespaced with the reserved dctrn_ prefix instead.
…ine and @PHPStan-Ignore This will allow for more defensive checks such as using narrower phpstan parameters that are also checked during runtime, without having to add phpstan ignores. Suggested in #12626 (comment)
Namespace the parameters generated for the cursor predicate
…s-certain Disable `treatPhpDocTypesAsCertain` phpstan option and clean up baseline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes for 3.7.2
3.7.x bugfix release (patch)
3.7.2
Static Analysis
treatPhpDocTypesAsCertainphpstan option and clean up baseline thanks to @whataboutpereiraBug
Test Suite