Skip to content

Over-engineering audit burn-down (ponytail, 2026-09-20) #114

Description

@devinmlowe

Summary

A whole-tree over-engineering audit (six parallel read-only passes over src/, scripts/, interfaces/, tests/, packaging and CI) found roughly 9,800 tracked lines and four npm dependencies that can be removed without changing behaviour, plus a 2.8 MB duplicate asset and about 1,840 lines of untracked loop artifacts.

Baseline before any cut: npm run build clean, npm run test:run 137 files / 1798 tests passing (2026-09-20).

Ground rules for every sub-issue

  • Run npm run build and npm run test:run before starting and after finishing. Both must stay green; the test count may only drop by tests that covered deleted code, and the PR must say which ones.
  • Work in a git worktree on a branch named ponytail/<slug>; merge to main with --no-ff.
  • Cuts that would remove a shipped or documented feature are labelled needs-decision and are not implemented until the maintainer confirms.

Sub-issues

Tracked as GitHub sub-issues below. Each one lists the exact findings (tag, file, estimated lines) it covers.

Findings not turned into work

  • DoctorContext / SetupDeps dependency injection: the injection exists so the doctor and setup test suites can run without touching the machine. Removing it would delete those tests. Kept.
  • Bridge re-opening the daemon session under the host's clientInfo: this is decision Decision: plugin: MCP transport — npx stdio or HTTP daemon? #60 (the forget actor must be the host, not engram-bridge). Kept.

Activity

  1. devinmlowe commented on Sep 21, 2026

    @devinmlowe
    OwnerAuthor

    Burn-down status (2026-09-21)

    All twelve implementable sub-issues are merged to main (each via its own ponytail/* branch and a --no-ff merge): #115 (PR #129), #116 (#134), #117 (#128), #118 (#130), #119 (#137), #120 (#135), #121 (#139), #122 (#131), #123 (#136), #124 (#140), #125 (#132), #126 (#141).

    Totals from the pre-audit baseline (9e0c156) to main (08da145):

    Area Files Added Removed
    src, scripts, interfaces, package.json 116 2,884 8,615
    tests 89 2,474 4,101
    everything 222 5,419 13,094

    Dependencies removed: @anthropic-ai/sdk, graphology-components, graphology-shortest-path, graphology-traversal. Nine runtime dependencies remain. assets/galaxy-view.webp (2.8 MB) removed.

    Tests: baseline 137 files / 1798 tests; main now 133 files / 1702 tests, green on every merge and on two consecutive runs after the last one. Every dropped case covered deleted code and is listed in its PR; #119 and #126 added tests (schema-drift snapshot, renderer, Anthropic wire contract).

    Deployed: ai.hermes.engram-mcp (9907) and com.engram.visualizer (3001) were restarted on the new build; /health answers and initialize returns a session.

    Still open: #127 (needs-decision list, maintainer's call) and one manual step, rm -r autoresearch in the main checkout (untracked; agent hooks block recursive deletes). Follow-up bug filed: #138. This issue stays open until #127 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestponytailOver-engineering audit cut (2026-09-20)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions