Fix scheduler state after backend failure - #201
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
flash_mla_with_kvcachecurrently setshave_initializedand stores the first-call configuration before the CUDA backend has generated scheduling metadata.If that backend call raises, the
FlashMLASchedMetaobject is left in a partially initialized state: it has a committed configuration but no metadata. A retry with corrected input shapes is then rejected by the stale configuration checks before it can reach the backend.Fix
Build the prospective first-call configuration locally, invoke the backend, and commit the configuration and initialized flag only after the backend returns successfully. Existing metadata reuse and consistency checks are unchanged after a successful call.
Regression coverage
The new CPU-only wrapper test fault-injects the CUDA extension:
Before this fix, step 2 fails and the retry is rejected without a second backend call.
Validation
uv run --with torch --with numpy python -m unittest tests/test_flash_mla_interface_unit.pyuvx ruff check tests/test_flash_mla_interface_unit.pypython3 -m compileall -q flash_mla tests/test_flash_mla_interface_unit.pygit diff --checkPrepared with OpenAI Codex assistance; I reproduced the failure and reviewed the change.