Mark auxiliary LSE output non-differentiable - #203
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SM100 prefill autograd function returns both attention output and an auxiliary log-sum-exp tensor. PyTorch currently marks both outputs as differentiable when any input requires gradients, but
backwardexplicitly discardsdlse. This advertises an LSE gradient path that the implementation does not support.Fix
Mark the returned LSE tensor non-differentiable with
ctx.mark_non_differentiable. LSE remains saved for computing the supported attention-output gradient.Regression coverage
The new CPU-only test loads the wrapper with an isolated fake CUDA backend and verifies that:
requires_gradnor a gradient functionValidation
python -m unittest tests.test_flash_mla_autograd_unitruff check tests/test_flash_mla_autograd_unit.pygit diff --checkThis is independent of #201 and #202; it changes only the SM100 prefill autograd contract.
Prepared with OpenAI Codex assistance; I reproduced the unsupported gradient path and reviewed the change.